Skip to content

tools: enable no-empty ESLint rule #41831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 8 commits into from
Closed

tools: enable no-empty ESLint rule #41831

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c4a07b
benchmark: enable no-empty ESLint rule
Trott Feb 3, 2022
c5f6b0f
doc: remove empty block from console.timeEnd() example
Trott Feb 3, 2022
6f975e4
doc: add comments to empty blocks in worker_threads text
Trott Feb 3, 2022
a560d6f
lib: add comments to empty catch statements
Trott Feb 3, 2022
81c2d33
policy: revise manifest.js to avoid empty blocks
Trott Feb 3, 2022
3db84ab
stream: remove empty block
Trott Feb 3, 2022
934d131
test: enable no-empty ESLint rule
Trott Feb 3, 2022
ab228c3
tools: enable no-empty ESLint rule
Trott Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
policy: revise manifest.js to avoid empty blocks
  • Loading branch information
@Trott
Trott committed Feb 5, 2022
commit 81c2d33c270dbaf18f1e6ea5fcab71577be469c9
8 changes: 3 additions & 5 deletions lib/internal/policy/manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,12 +430,11 @@ class Manifest {

if (objectButNotArray(obj) && 'onerror' in obj) {
const behavior = obj.onerror;
if (behavior === 'throw') {
} else if (behavior === 'exit') {
if (behavior === 'exit') {
reaction = REACTION_EXIT;
} else if (behavior === 'log') {
reaction = REACTION_LOG;
} else {
} else if (behavior !== 'throw') {
throw new ERR_MANIFEST_UNKNOWN_ONERROR(behavior);
}
}
Expand Down Expand Up @@ -579,8 +578,7 @@ class Manifest {
const entry = this.#scopeIntegrities.get(scope);
if (entry === true) {
return true;
} else if (entry === kCascade) {
} else {
} else if (entry !== kCascade) {
break;
}
}
Expand Down