Skip to content

fs: support copy of relative links with cp and cpSync #41819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 12 commits into from
Feb 15, 2022
Merged

fs: support copy of relative links with cp and cpSync #41819

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eed1481
fs: support copy of relative links with cp and cpSync
marcosbc Feb 2, 2022
65d214c
Fix linter warning
marcosbc Feb 2, 2022
f3bd1f2
Ensure 'absolute' is a boolean and true by default
marcosbc Feb 2, 2022
df8024d
Change absolute approach to verbatimSymlinks
marcosbc Feb 2, 2022
3071c63
Add changes entries in YAML docs for fs.cp/fs.cpSync/fs.promises.cp
marcosbc Feb 2, 2022
4c1324e
Fix linter warning
marcosbc Feb 2, 2022
26c333a
Apply wording suggestions
marcosbc Feb 2, 2022
5d7756a
Add suggested validations
marcosbc Feb 2, 2022
4cd07ac
options.dereference and options.verbatimSymlink should be mutually ex…
marcosbc Feb 2, 2022
aa29c91
Fix error type used for tests
marcosbc Feb 2, 2022
eecce13
Implement feedback: Fix descriptions, use ERR_INCOMPATIBLE_OPTION_PAIR
marcosbc Feb 8, 2022
7527fdc
Remove unrelated file
marcosbc Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix linter warning 
Signed-off-by: Marcos Bjoerkelund <marcosbd@vmware.com>
  • Loading branch information
@marcosbc
marcosbc committed Feb 8, 2022
commit 65d214c5471a7ff98366301279066f4eb8781adb
1 change: 0 additions & 1 deletion test/parallel/test-fs-cp.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ function nextdir() {

const dest = nextdir();
mkdirSync(dest, { recursive: true });
const destFile = join(dest, 'foo.js');

cpSync(src, dest, { recursive: true, absolute: false });
const link = readlinkSync(join(dest, 'bar.js'));
Expand Down