Skip to content

worker: improve code coverage #41818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Feb 11, 2022
Merged

worker: improve code coverage #41818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b9e60b
worker: improve code coverage for assignEnvironmentData function
ErickWendel Feb 1, 2022
0a3e3c7
worker: improve code coverage for getHeapSnapshot
ErickWendel Feb 1, 2022
0bceab4
worker: add mustCall to the event to ensure the assert will be called…
ErickWendel Feb 1, 2022
3027e15
worker: add test for heapsnapshot as an integration test
ErickWendel Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
worker: improve code coverage for getHeapSnapshot
  • Loading branch information
@ErickWendel
ErickWendel committed Feb 1, 2022
commit 0a3e3c705f42ae4e1c012b5f983a368045c3a221
1 change: 1 addition & 0 deletions lib/internal/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,7 @@ function eventLoopUtilization(util1, util2) {
}

module.exports = {
kHandle,
Comment thread
ErickWendel marked this conversation as resolved.
Outdated
ownsProcessState,
isMainThread,
SHARE_ENV,
Expand Down
22 changes: 22 additions & 0 deletions test/parallel/test-worker-heap-snapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
'use strict';

// Flags: --expose-internals
const common = require('../common');
const assert = require('assert');
const { Worker } = require('worker_threads');
const { HeapSnapshotStream } = require('internal/heap_utils');
const { kHandle } = require('internal/worker');

const worker = new Worker(__filename);
Comment thread
ErickWendel marked this conversation as resolved.
Outdated
const snapShotResult = { ondone: () => {} };
worker[kHandle].takeHeapSnapshot = common.mustCall(() => snapShotResult);

worker.on('online', () => {
Comment thread
ErickWendel marked this conversation as resolved.
Outdated
const snapShotResponse = worker.getHeapSnapshot();
snapShotResult.ondone({});

snapShotResponse.then(common.mustCall((heapSnapshotStream) => {
assert.ok(heapSnapshotStream instanceof HeapSnapshotStream);
Comment thread
ErickWendel marked this conversation as resolved.
Outdated
worker.terminate();
}));
});