Skip to content

crypto: check return code from EVP_DigestUpdate #41800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 2 commits into from
Closed

crypto: check return code from EVP_DigestUpdate #41800

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5239bb
crypto: check return code from EVP_DigestUpdate
mhdawson Jan 31, 2022
7c08322
Update src/crypto/crypto_hash.cc
mhdawson Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
crypto: check return code from EVP_DigestUpdate 
Coverity was complaining that we did not check the
return code. We seem to check in the other place it
is called and the method already handles returning
a result.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
  • Loading branch information
@mhdawson
mhdawson committed Jan 31, 2022
commit b5239bb9621869a4d311bf4230f59d14c6f4c942
3 changes: 1 addition & 2 deletions src/crypto/crypto_hash.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ bool Hash::HashInit(const EVP_MD* md, Maybe<unsigned int> xof_md_len) {
bool Hash::HashUpdate(const char* data, size_t len) {
if (!mdctx_)
return false;
EVP_DigestUpdate(mdctx_.get(), data, len);
return true;
return EVP_DigestUpdate(mdctx_.get(), data, len);
Comment thread
mhdawson marked this conversation as resolved.
Outdated
}

void Hash::HashUpdate(const FunctionCallbackInfo<Value>& args) {
Expand Down