Skip to content

[v16.x Backport] Import assertions related PRs #41776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 5 commits into from
Closed

[v16.x Backport] Import assertions related PRs #41776

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdee445
esm: add support for JSON import assertion
aduh95 Aug 27, 2021
0d728a3
test: disable warnings to fix flaky test
aduh95 Nov 6, 2021
7ad3028
doc: fix spelling of 'WebAssembly'
GeoffreyBooth Nov 10, 2021
55fdfb2
module: import assertions improvements
GeoffreyBooth Nov 10, 2021
e79707e
esm: refactor esm tests out of test/message
GeoffreyBooth Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix spelling of 'WebAssembly' 
PR-URL: #40785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@GeoffreyBooth @aduh95
GeoffreyBooth authored and aduh95 committed Jan 31, 2022
commit 7ad30284542ec76cf6de09c7a425d25bb108cbae
6 changes: 3 additions & 3 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,12 +554,12 @@ node --experimental-json-modules index.mjs # works

> Stability: 1 - Experimental

Importing Web Assembly modules is supported under the
Importing WebAssembly modules is supported under the
`--experimental-wasm-modules` flag, allowing any `.wasm` files to be
imported as normal modules while also supporting their module imports.

This integration is in line with the
[ES Module Integration Proposal for Web Assembly][].
[ES Module Integration Proposal for WebAssembly][].

For example, an `index.mjs` containing:

Expand Down Expand Up @@ -1405,7 +1405,7 @@ success!
[Core modules]: modules.md#core-modules
[Dynamic `import()`]: https://wiki.developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#Dynamic_Imports
[ECMAScript Top-Level `await` proposal]: https://github.com/tc39/proposal-top-level-await/
[ES Module Integration Proposal for Web Assembly]: https://github.com/webassembly/esm-integration
[ES Module Integration Proposal for WebAssembly]: https://github.com/webassembly/esm-integration
[Import Assertions proposal]: https://github.com/tc39/proposal-import-assertions
[JSON modules]: #json-modules
[Node.js Module Resolution Algorithm]: #resolver-algorithm-specification
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/translators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ translators.set('json', async function jsonStrategy(url, source) {

// Strategy for loading a wasm module
translators.set('wasm', async function(url, source) {
emitExperimentalWarning('Importing Web Assembly modules');
emitExperimentalWarning('Importing WebAssembly modules');

assertBufferSource(source, false, 'load');

Expand Down
2 changes: 1 addition & 1 deletion test/es-module/test-esm-wasm.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ child.on('close', (code, signal) => {
strictEqual(code, 0);
strictEqual(signal, null);
ok(stderr.toString().includes(
'ExperimentalWarning: Importing Web Assembly modules is ' +
'ExperimentalWarning: Importing WebAssembly modules is ' +
'an experimental feature. This feature could change at any time'
));
});