Skip to content

crypto: fix webcrypto.subtle signature #41761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Jan 31, 2022
Merged

crypto: fix webcrypto.subtle signature #41761

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e552e64
crypto: fix `webcrpto.subtle` signature
aduh95 Jan 29, 2022
9487683
fixup! crypto: fix `webcrpto.subtle` signature
aduh95 Jan 29, 2022
eed2ae8
fixup! fixup! crypto: fix `webcrpto.subtle` signature
aduh95 Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
crypto: fix webcrpto.subtle signature
  • Loading branch information
@aduh95
aduh95 committed Jan 29, 2022
commit e552e64f2c3b799f7cf2aa95d94d1f369fd999dd
11 changes: 5 additions & 6 deletions lib/internal/crypto/webcrypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,11 @@ async function decrypt(algorithm, key, data) {
class SubtleCrypto {}
const subtle = new SubtleCrypto();

class Crypto {}
class Crypto {
get subtle() {
return subtle;
}
}
const crypto = new Crypto();

ObjectDefineProperties(
Expand All @@ -698,11 +702,6 @@ ObjectDefineProperties(
writable: false,
value: 'Crypto',
},
subtle: {
enumerable: true,
configurable: false,
value: subtle,
},
getRandomValues: {
enumerable: true,
configurable: true,
Expand Down