Skip to content

src: slightly simplify URLHost::ToString #41747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

src: slightly simplify URLHost::ToString #41747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: slightly simplify URLHost::ToString
  • Loading branch information
@addaleax
addaleax committed Jan 29, 2022
commit 6d5b5460e7fcfdcf6cc4a9044b99f2ff4c4f6a03
4 changes: 1 addition & 3 deletions src/node_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,9 +582,7 @@ std::string URLHost::ToString() const {
dest.reserve(15);
uint32_t value = value_.ipv4;
for (int n = 0; n < 4; n++) {
char buf[4];
snprintf(buf, sizeof(buf), "%d", value % 256);
dest.insert(0, buf);
dest.insert(0, std::to_string(value % 256));
if (n < 3)
dest.insert(0, 1, '.');
value /= 256;
Expand Down