Skip to content

http2: fix no response event on continue request #41739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Feb 3, 2022
Merged

http2: fix no response event on continue request #41739

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5289fc6
http2: fix no response event on continue request
Jan 29, 2022
e147b0e
fix liniting issues
Jan 29, 2022
8609ae4
correct the fix
Jan 29, 2022
91db9b4
simplify condition
Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correct the fix
  • Loading branch information
ofir committed Jan 30, 2022
commit 8609ae4634e0b9dbf67605f52f3c55cfdfc07fc9
4 changes: 1 addition & 3 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,9 +760,7 @@ class Http2ServerResponse extends Stream {
}

if (chunk !== null && chunk !== undefined)
chunk = '';

this.write(chunk, encoding);
this.write(chunk, encoding);

state.headRequest = stream.headRequest;
state.ending = true;
Expand Down
4 changes: 3 additions & 1 deletion lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,11 @@ function onSessionHeaders(handle, id, cat, flags, headers, sensitiveHeaders) {
}
} else if (cat === NGHTTP2_HCAT_PUSH_RESPONSE) {
event = 'push';
// cat === NGHTTP2_HCAT_HEADERS:
} else if (!endOfStream && status !== undefined && status >= 200) {
event = 'response';
} else if (endOfStream && status !== undefined && status >= 200) {
// cat === NGHTTP2_HCAT_HEADERS
event = 'response';
Comment thread
Linkgoron marked this conversation as resolved.
} else {
event = endOfStream ? 'trailers' : 'headers';
}
Expand Down