Skip to content

tools,test,lib: enable no-cond-assign ESLint rule #41614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 9 commits into from
Jan 23, 2022
Merged

tools,test,lib: enable no-cond-assign ESLint rule #41614

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c05c883
crypto: revise variables for const use instead of let
Trott Jan 20, 2022
e6fdcbe
stream: check for null instead of falsy in loops
Trott Jan 20, 2022
0bc6422
policy: check for null instead of falsy in loop
Trott Jan 20, 2022
e044a5d
process: check for null instead of falsy in while loop
Trott Jan 20, 2022
bd42245
timers: check for nullish instead of falsy in loops
Trott Jan 20, 2022
ac06951
util: check for null instead of flasy in loop
Trott Jan 20, 2022
348469b
repl: check for precise values rather than falsy in loops
Trott Jan 20, 2022
d77754b
test: prepare tests for no-cond-assign ESLint rule
Trott Jan 20, 2022
68bb83f
tools: enable no-cond-assign-ESLint rule
Trott Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
repl: check for precise values rather than falsy in loops 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@Trott
Trott committed Jan 23, 2022
commit 348469b87a191acd7b5826526ca8f6c7af7daca1
4 changes: 2 additions & 2 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ function REPLServer(prompt,
paused = false;
let entry;
const tmpCompletionEnabled = self.isCompletionEnabled;
while (entry = ArrayPrototypeShift(pausedBuffer)) {
while ((entry = ArrayPrototypeShift(pausedBuffer)) !== undefined) {
const { 0: type, 1: payload, 2: isCompletionEnabled } = entry;
switch (type) {
case 'key': {
Expand Down Expand Up @@ -1450,7 +1450,7 @@ function complete(line, callback) {
ArrayPrototypePush(completionGroups,
getGlobalLexicalScopeNames(this[kContextId]));
let contextProto = this.context;
while (contextProto = ObjectGetPrototypeOf(contextProto)) {
while ((contextProto = ObjectGetPrototypeOf(contextProto)) !== null) {
ArrayPrototypePush(completionGroups,
filteredOwnPropertyNames(contextProto));
}
Expand Down