Skip to content

test: fix typo in test_js_native_api_v8 #41584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 1 commit into from
Closed

test: fix typo in test_js_native_api_v8 #41584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix typo in test_js_native_api_v8
  • Loading branch information
@tniessen
tniessen authored Jan 18, 2022
commit 6fa3aba7f0ad7d8ccf256e3ca904add4b929b780
2 changes: 1 addition & 1 deletion test/cctest/test_js_native_api_v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ TEST_F(JsNativeApiV8Test, Reference) {

// We can hardly trigger a non-forced Garbage Collection in a stable way.
// Here we just invoke the weak callbacks directly.
// The persistant handles should be reset in the weak callback in respect
// The persistent handles should be reset in the weak callback in respect
// to the API contract of v8 weak callbacks.
v8::WeakCallbackInfo<Reference::SecondPassCallParameterRef> data(
reinterpret_cast<v8::Isolate*>(isolate_),
Expand Down