Skip to content

[v16.x] deps: V8: cherry-pick d8dc66f #41566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luyahan wants to merge 5 commits into from
Closed

[v16.x] deps: V8: cherry-pick d8dc66f #41566

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1dd8202
deps: V8: cherry-pick d8dc66f92169
luyahan Jan 17, 2022
12920f9
deps: V8: cherry-pick 3cab84c24723
luyahan Jan 17, 2022
c203eeb
deps: V8: cherry-pick 471f862954f3
luyahan Jan 17, 2022
81e50d8
deps: V8: cherry-pick e74d6918fb9f
luyahan Jan 17, 2022
f18bb63
deps: V8: backport 77599ffe0a74
luyahan Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: V8: backport 77599ffe0a74 
Original commit message:

    [riscv64] Add block before LoadAddress

    fix node.js DCHECK failed
    issue: riscv-collab/v8#514

    Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Commit-Queue: ji qiu <qiuji@iscas.ac.cn>
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#77750}

Refs: v8/v8@77599ffe0a74
  • Loading branch information
@luyahan
luyahan committed Jan 17, 2022
commit f18bb63439fdff1c4a517276277ec16e7026ef99
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.18',
'v8_embedder_string': '-node.19',

##### V8 defaults for Node.js #####

Expand Down
1 change: 1 addition & 0 deletions deps/v8/src/baseline/riscv64/baseline-assembler-riscv64-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,7 @@ void BaselineAssembler::Switch(Register reg, int case_value_base,
DCHECK(is_int32(imm64));
int32_t Hi20 = (((int32_t)imm64 + 0x800) >> 12);
int32_t Lo12 = (int32_t)imm64 << 20 >> 20;
__ BlockTrampolinePoolFor(2);
__ auipc(temp, Hi20); // Read PC + Hi20 into t6
__ addi(temp, temp, Lo12); // jump PC + Hi20 + Lo12

Expand Down
1 change: 1 addition & 0 deletions deps/v8/src/codegen/riscv64/macro-assembler-riscv64.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3485,6 +3485,7 @@ void TurboAssembler::LoadAddress(Register dst, Label* target,
if (CalculateOffset(target, &offset, OffsetSize::kOffset32)) {
int32_t Hi20 = (((int32_t)offset + 0x800) >> 12);
int32_t Lo12 = (int32_t)offset << 20 >> 20;
BlockTrampolinePoolScope block_trampoline_pool(this);
auipc(dst, Hi20);
addi(dst, dst, Lo12);
} else {
Expand Down