Skip to content

child_process: apply hide_console_windows to spawnSync calls #41412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Feb 11, 2022
Merged

child_process: apply hide_console_windows to spawnSync calls #41412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
child_process: kHideConsoleWindows for spawnSync 
kHideConsoleWindows should hide console windows for
execSync and spawnSync calls as well. This fix adds on
to #39712.
  • Loading branch information
@rzhao271
rzhao271 committed Jan 5, 2022
commit 92ea0d3a80e0f043f9b3ac2cf50f479eaf935a63
3 changes: 3 additions & 0 deletions src/spawn_sync.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,9 @@ Maybe<int> SyncProcessRunner::ParseOptions(Local<Value> js_value) {
if (js_win_hide->BooleanValue(isolate))
uv_process_options_.flags |= UV_PROCESS_WINDOWS_HIDE;

if (env()->hide_console_windows())
uv_process_options_.flags |= UV_PROCESS_WINDOWS_HIDE_CONSOLE;

Local<Value> js_wva =
js_options->Get(context, env()->windows_verbatim_arguments_string())
.ToLocalChecked();
Expand Down