Skip to content

net: add new options to net.Socket and net.Server #41310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Feb 22, 2022
Merged

net: add new options to net.Socket and net.Server #41310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d745c
net: add new options to `net.Socket` and `net.Server`
ShogunPanda Dec 28, 2021
220fa69
net: remove useless timers
ShogunPanda Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
net: remove useless timers
  • Loading branch information
@ShogunPanda
ShogunPanda committed Jan 5, 2022
commit 220fa698dda765b62d30ffa1b2996c523b2cac47
21 changes: 12 additions & 9 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,31 +517,34 @@ Socket.prototype._onTimeout = function() {


Socket.prototype.setNoDelay = function(enable) {
// Backwards compatibility: assume true when `enable` is omitted
enable = Boolean(enable === undefined ? true : enable);

if (!this._handle) {
this.once('connect',
enable ? this.setNoDelay : () => this.setNoDelay(enable));
this[kSetNoDelay] = enable;
return this;
}

// Backwards compatibility: assume true when `enable` is omitted
const newValue = enable === undefined ? true : !!enable;
if (this._handle.setNoDelay && newValue !== this[kSetNoDelay]) {
this[kSetNoDelay] = newValue;
this._handle.setNoDelay(newValue);
if (this._handle.setNoDelay && enable !== this[kSetNoDelay]) {
this[kSetNoDelay] = enable;
this._handle.setNoDelay(enable);
}

return this;
};


Socket.prototype.setKeepAlive = function(enable, initialDelayMsecs) {
enable = Boolean(enable);
const initialDelay = ~~(initialDelayMsecs / 1000);

if (!this._handle) {
this.once('connect', () => this.setKeepAlive(enable, initialDelayMsecs));
this[kSetKeepAlive] = enable;
this[kSetKeepAliveInitialDelay] = initialDelay;
return this;
}

if (this._handle.setKeepAlive && enable !== this[kSetKeepAlive]) {
const initialDelay = ~~(initialDelayMsecs / 1000);
this[kSetKeepAlive] = enable;
this[kSetKeepAliveInitialDelay] = initialDelay;
this._handle.setKeepAlive(enable, initialDelay);
Expand Down