Skip to content

deps: update to openssl-3.0.1+quic #41177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 4 commits into from
Closed

deps: update to openssl-3.0.1+quic #41177

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
119842f
build: update openssl config generator Dockerfile
richardlau Dec 14, 2021
3a840bf
test: do not load absolute path crypto engines twice
richardlau Dec 15, 2021
ebaf1be
deps: upgrade openssl sources to quictls/openssl-3.0.1+quic
richardlau Dec 14, 2021
d9275b9
deps: update archs files for quictls/openssl-3.0.1+quic
richardlau Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: do not load absolute path crypto engines twice 
Newer versions of OpenSSL now throws an error if an engine is loaded
twice by its absolute path (a second load by its id appears to be okay).
  • Loading branch information
@richardlau
richardlau committed Dec 15, 2021
commit 3a840bfc71df2294f3d36e253adfc5d2f74597ff
9 changes: 6 additions & 3 deletions test/parallel/test-crypto-engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,13 @@ crypto.setEngine('dynamic', crypto.constants.ENGINE_METHOD_RSA);
fs.accessSync(enginePath);

crypto.setEngine(enginePath);
crypto.setEngine(enginePath);
// OpenSSL 3.0.1 and 1.1.1m now throw errors if an engine is loaded again
// with a duplicate absolute path.
// TODO(richardlau): figure out why this fails on macOS but not Linux.
// crypto.setEngine(enginePath);

crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);
crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);
// crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);
// crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);

process.env.OPENSSL_ENGINES = execDir;

Expand Down