Skip to content

stream: add isErrored helper #41121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 6 commits into from
Closed

stream: add isErrored helper #41121

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ade6e3
stream: add isErrored helper
ronag Dec 9, 2021
47b2605
Apply suggestions from code review
ronag Dec 9, 2021
571739e
Update doc/api/stream.md
ronag Dec 9, 2021
e656060
Update doc/api/stream.md
ronag Dec 9, 2021
44d58f9
fixup
ronag Dec 10, 2021
bb4e9f0
fixup
ronag Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@ronag
ronag committed Dec 16, 2021
commit bb4e9f01e9eb2214af5c24404e503c7c51d27379
7 changes: 3 additions & 4 deletions test/parallel/test-whatwg-readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,16 +1576,15 @@ class Source {

{
const stream = new ReadableStream({
start(controller) {
pull: common.mustCall((controller) => {
controller.error(new Error());
},
pull: common.mustNotCall(),
}),
});

const reader = stream.getReader();
(async () => {
isErrored(stream, false);
await reader.read();
await reader.read().catch(common.mustCall());
isErrored(stream, true);
})().then(common.mustCall());
}