Skip to content

tools: consolidate ESLint dependencies #40995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

tools: consolidate ESLint dependencies #40995

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45422db
tools: run ESLint update to minimize diff on subsequent update
Trott Nov 27, 2021
6fd0a60
tools: update ESLint update script to consolidate dependencies
Trott Nov 27, 2021
4c41fea
tools: consolidate ESLint dependencies
Trott Nov 27, 2021
6d8ab76
tools: remove unneeded tool in update-eslint.sh
Trott Nov 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools: remove unneeded tool in update-eslint.sh 
The tool to remove absolute paths from package.json files is no longer
necessary. It appears that npm no longer stores these paths, or at least
not in a way that causes the kind of churn we saw in the past.

PR-URL: #40995
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Trott
Trott committed Nov 29, 2021
commit 6d8ab767e430dbe4ec5d3641b6201913fadba269
3 changes: 0 additions & 3 deletions tools/update-eslint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ rm -rf node_modules/eslint
"$NODE" "$NPM" exec -- dmn@2.2.2 -f clean
# TODO: Get this into dmn.
find node_modules -name .package-lock.json -exec rm {} \;
# Use removeNPMAbsolutePaths to remove unused data in package.json.
# This avoids churn as absolute paths can change from one dev to another.
"$NODE" "$NPM" exec -- removeNPMAbsolutePaths@1.0.4 .
)

mv eslint-tmp/node_modules/eslint node_modules/eslint
Expand Down