Skip to content

loader: return package format from defaultResolve if known #40980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Dec 13, 2021
Merged

loader: return package format from defaultResolve if known #40980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54e305
loader: return package format from defaultResolve if known
dygabo Nov 26, 2021
2d2c475
fixup! loader: return package format from defaultResolve if known
dygabo Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! loader: return package format from defaultResolve if known
  • Loading branch information
@dygabo
dygabo committed Dec 13, 2021
commit 2d2c4754322117dd5ccf362206e45be42c0edfb8
3 changes: 1 addition & 2 deletions test/es-module/test-esm-loader-resolve-type.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { allowGlobals } from '../common/index.mjs';
import * as fixtures from '../common/fixtures.mjs';
import { strict as assert } from 'assert';
import * as fs from 'fs';
import { fileURLToPath } from 'url';

allowGlobals(global.getModuleTypeStats);

Expand Down Expand Up @@ -32,7 +31,7 @@ const { importedESM: importedESMBefore,
importedCJS: importedCJSBefore } = global.getModuleTypeStats();

import(`${moduleName}`).finally(() => {
fs.rmSync(fileURLToPath(basePath), { recursive: true, force: true });
fs.rmSync(basePath, { recursive: true, force: true });
});

const { importedESM: importedESMAfter,
Expand Down