Skip to content

test: deflake cluster-concurrent-disconnect #40877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Nov 21, 2021
Merged

test: deflake cluster-concurrent-disconnect #40877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: deflake cluster-concurrent-disconnect 
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: #38405
  • Loading branch information
@lpinca
lpinca committed Nov 19, 2021
commit 4e346e85cfbb7a10a47f7508f59fe328eed4ca49
6 changes: 5 additions & 1 deletion test/parallel/test-cluster-concurrent-disconnect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ if (cluster.isPrimary) {
// to send messages when the worker is disconnecting.
worker.on('error', (err) => {
assert.strictEqual(err.syscall, 'write');
assert.strictEqual(err.code, 'EPIPE');
if (common.isOSX) {
assert(['EPIPE', 'ENOTCONN'].includes(err.code), err);
} else {
assert.strictEqual(err.code, 'EPIPE');
}
});

worker.once('disconnect', common.mustCall(() => {
Expand Down