Skip to content

stream: add map method to Readable: #40815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 19 commits into from
+317 −3
Closed

stream: add map method to Readable: #40815

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f5dfa00
stream: add map method to Readable
benjamingr Nov 15, 2021
eae40bc
test code review
benjamingr Nov 21, 2021
7678628
fixup
ronag Nov 29, 2021
55eb7ff
fixup: explicit listener
ronag Nov 29, 2021
66fbd9f
fixup
ronag Nov 29, 2021
416e462
fixup
ronag Nov 29, 2021
5a22655
Update lib/internal/streams/operators.js
ronag Nov 30, 2021
2e7c469
fixup
ronag Dec 3, 2021
751b429
fixup
ronag Dec 3, 2021
d91ddda
fixup
ronag Dec 3, 2021
0679c79
fixup
ronag Dec 4, 2021
a8e9dd6
fixup
ronag Dec 4, 2021
2db5501
fixup
ronag Dec 4, 2021
7045b68
Apply suggestions from code review
ronag Dec 27, 2021
c61f6ba
fixup
ronag Dec 29, 2021
7e617c2
Update lib/stream.js
ronag Dec 29, 2021
47d9891
fixup
ronag Dec 29, 2021
2d7cd8c
fixup
ronag Dec 29, 2021
686d9e6
ifxuo
ronag Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Dec 27, 2021
commit 7678628bb083ea193ec25a5e043458c4d7ce81bc
12 changes: 7 additions & 5 deletions lib/internal/streams/operators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ const {
ERR_INVALID_ARG_VALUE,
}, AbortError,
Comment thread
ronag marked this conversation as resolved.
Outdated
} = require('internal/errors');
const {
validateInteger,
validateObject,
} = require('internal/validators');

const {
MathFloor,
NumberIsInteger,
Promise,
PromiseReject,
Symbol,
Expand All @@ -30,15 +33,14 @@ async function * map(fn, options) {
throw new ERR_INVALID_ARG_TYPE('options', ['Object']);
}

validateObject(options, 'options', { nullable: true });

let concurrency = 1;
if (options?.concurrency != null) {
concurrency = MathFloor(options.concurrency);
}

if (!NumberIsInteger(concurrency)) {
throw new ERR_INVALID_ARG_TYPE(
'concurrency', ['Integer'], concurrency);
}
validateInteger(concurrency, 'concurrency', 1);

if (concurrency < 1) {
throw new ERR_INVALID_ARG_VALUE('concurrency', concurrency);
Expand Down