Skip to content

doc: update conditions, add "deno" and "types" #40708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 15 commits into from
Closed

doc: update conditions, add "deno" and "types" #40708

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8b3bf21
doc: endorse "source" and "deno" conditions
guybedford Nov 3, 2021
de4eab6
fixup: add "types" as well
guybedford Nov 3, 2021
31071a5
fixup: style
guybedford Nov 3, 2021
949bb7c
remove "source", clarify "development"
guybedford Nov 3, 2021
d943a22
reorder conditions in specificity ordering, note
guybedford Nov 3, 2021
804dd2a
fixup: clarify Node.js condition, remove restriction wording
guybedford Nov 4, 2021
5791560
clarify browser condition
guybedford Nov 4, 2021
22eceb1
fixup: review typo
guybedford Nov 5, 2021
599f4eb
fixup: typo v2
guybedford Nov 5, 2021
502ae3c
fixup: code review
guybedford Nov 8, 2021
1a83be2
fixup: code review
guybedford Nov 8, 2021
bf8c702
update description of conditions definitions
guybedford Nov 17, 2021
438c179
rename title, further rewording
guybedford Nov 17, 2021
eb9f27e
linting fixes
guybedford Nov 17, 2021
7cefba2
remove singular types note
guybedford Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: code review 
Co-authored-by: Geoffrey Booth <456802+GeoffreyBooth@users.noreply.github.com>
  • Loading branch information
@guybedford @GeoffreyBooth
guybedford and GeoffreyBooth authored Nov 8, 2021
commit 1a83be25ce4f5d91182aa632b5ed59c28c1e6817
2 changes: 1 addition & 1 deletion doc/api/packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ The above user conditions can be enabled in Node.js via the

Platform-specific conditions such as `"electron"`, or `"react-native"` may
Comment thread
guybedford marked this conversation as resolved.
Outdated
be used, but while there remain no implementation or integration intent
from these platforms, we do not yet explicitly recommend them.
from these platforms, they are not currently explicitly recommended.
Comment thread
guybedford marked this conversation as resolved.
Outdated

New conditions definitions may be added to this list by creating a pull request
to the [Node.js documentation for this section][]. The requirements for listing
Expand Down