Skip to content

fix: Blob constructor on various ArrayBuffer views #40706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 8 commits into from
Dec 10, 2021
Merged

fix: Blob constructor on various ArrayBuffer views #40706

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a85bc3
fix: Blob constructor on various ArrayBuffer views
Gozala Nov 2, 2021
cf3abfd
fix: only copy necessary bytes
Gozala Nov 2, 2021
ccc06b7
chore: add test case
Gozala Nov 2, 2021
bcab31e
fix: slice buffer from both sides
Gozala Nov 3, 2021
95ca174
Update test/parallel/test-blob.js
Gozala Nov 3, 2021
42f3f74
fix: address lint & test errors
Gozala Nov 3, 2021
9791e08
fix: lint error at test/parallel/test-blob.js
Gozala Nov 3, 2021
df6ad22
chore: fix test failures for big endian hosts
Gozala Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add test case
  • Loading branch information
@Gozala
Gozala authored Nov 2, 2021
commit ccc06b72f3e87aff7e8afa2b50b4e8395079ac49
15 changes: 15 additions & 0 deletions test/parallel/test-blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,3 +220,18 @@ assert.throws(() => new Blob({}), {
});
});
}

Copy link
Copy Markdown
Contributor Author

@Gozala Gozala Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Based on test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js
// which is disabled due to dependency on other web APIs.
// Exercises #40705

@aduh95 does this look good ?

(async () => {
const blob = new Blob([
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have a comment referencing where this test is coming from.

new Uint8Array([0x50, 0x41, 0x53, 0x53]),
new Int8Array([0x50, 0x41, 0x53, 0x53]),
new Uint16Array([0x4150, 0x5353]),
new Int16Array([0x4150, 0x5353]),
new Uint32Array([0x53534150]),
new Int32Array([0x53534150]),
new Float32Array([0xD341500000])
Comment thread
Gozala marked this conversation as resolved.
Outdated
]);

assert.equal(blob.text(), "PASSPASSPASSPASSPASSPASSPASS");
Comment thread
Gozala marked this conversation as resolved.
Outdated
assert.equal(blob.type, "");
Comment thread
Gozala marked this conversation as resolved.
Outdated
})().then(common.mustCall());