Skip to content

deps: update ICU to 70.1 #40658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 2 commits into from
Closed

deps: update ICU to 70.1 #40658

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6dd74d
deps: update ICU to 70.1
targos Oct 29, 2021
fc4511a
doc: update maintaining ICU guide
targos Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: update maintaining ICU guide 
Do not ask to separate the changes in deps/icu-small and in the
LICENSE file.
Do not ask to remove the whitespace changes. The way commits are
landed now doesn't eliminate them anymore.
  • Loading branch information
@targos
targos committed Nov 2, 2021
commit fc4511ab7bc647f9ba90cd4df9e003c4b78df8ad
12 changes: 3 additions & 9 deletions doc/guides/maintaining-icu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ new Intl.DateTimeFormat('es', { month: 'long' }).format(new Date(9E8));

(This should print your updated ICU version number, and also `enero` again.)

You are ready to check in the updated `deps/icu-small`. This is a big commit,
so make this a separate commit from the smaller changes.
You are ready to check in (`git add`) the updated `deps/icu-small`.

> :warning: Do not modify any source code in `deps/icu-small` !
> See section below about floating patches to ICU.
Expand All @@ -185,13 +184,8 @@ make
make test-ci
```

* commit the change to `tools/icu/current_ver.dep` and `LICENSE` files.

* To simplify review, I often will “pre-land” this patch, meaning that I run
`curl -L https://github.com/nodejs/node/pull/xxx.patch | git am -3 --whitespace=fix`
per the collaborator’s guide… and then push that patched branch into my
PR's branch. This reduces the whitespace changes that show up in the PR,
since the final land will eliminate those anyway.
* Commit the change to the `deps/icu-small`, `tools/icu/current_ver.dep`
and `LICENSE` files.

## Floating patches to ICU

Expand Down