Skip to content

dgram: fix send with out of bounds offset + length #40568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linkgoron wants to merge 3 commits into from
Closed

dgram: fix send with out of bounds offset + length #40568

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63a0887
dgram: fix send with out of bounds offset + length
Linkgoron Oct 22, 2021
b392a94
fixup! dgram: fix send with out of bounds offset + length
Linkgoron Oct 22, 2021
c829552
fixup! fixup! dgram: fix send with out of bounds offset + length
Linkgoron Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! dgram: fix send with out of bounds offset + length
  • Loading branch information
@Linkgoron
Linkgoron committed Oct 24, 2021
commit c8295526df2ae0e8f900afc68ea0f1116d1fa146
7 changes: 4 additions & 3 deletions test/parallel/test-dgram-send-bad-arguments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,16 @@ function checkArgs(connected) {
}
);

const longArray = [1, 2, 3, 4, 5, 6, 7, 8];
for (const input of ['hello',
Buffer.from('hello'),
Buffer.from('hello world').subarray(0, 5),
Buffer.from('hello world').subarray(4, 9),
Buffer.from('hello world').subarray(6),
new Uint8Array([1, 2, 3, 4, 5]),
new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).slice(0, 5),
new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).slice(2, 7),
new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).slice(3),
new Uint8Array(longArray).subarray(0, 5),
new Uint8Array(longArray).subarray(2, 7),
new Uint8Array(longArray).subarray(3),
new DataView(new ArrayBuffer(5), 0),
new DataView(new ArrayBuffer(6), 1),
new DataView(new ArrayBuffer(7), 1, 5)]) {
Expand Down