Skip to content

v17.0.1 release proposal #40535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 10 commits into from
Oct 20, 2021
Merged

v17.0.1 release proposal #40535

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3f03355
build: include missing V8 headers in distribution
targos Oct 19, 2021
b84f101
stream: support array of streams in promises pipeline
Mesteery Sep 23, 2021
f9f2442
src: add missing inialization in agent.h
mhdawson Oct 8, 2021
7c42d9f
test: split test-crypto-dh.js
joyeecheung Oct 14, 2021
111f0bd
stream: fix fromAsyncGen
ronag Oct 18, 2021
977016a
doc: specify that maxFreeSockets is per host
lpinca Oct 16, 2021
adbd92e
crypto: avoid double free
mhdawson Oct 8, 2021
3f7c503
test: adjust CLI flags test to ignore blank lines in doc
Trott Oct 11, 2021
8dce85a
doc: format doc/api/*.md with markdown formatter
Trott Oct 11, 2021
d68dd62
2021-10-20, Version 17.0.1 (Current)
targos Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: adjust CLI flags test to ignore blank lines in doc 
PR-URL: #40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@Trott @targos
Trott authored and targos committed Oct 20, 2021
commit 3f7c503b69b9fe3db560d1e7a6103233d223773e
5 changes: 4 additions & 1 deletion test/parallel/test-process-env-allowed-flags-are-documented.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ const parseSection = (text, startMarker, endMarker) => {
const match = text.match(regExp);
assert(match,
`Unable to locate text between '${startMarker}' and '${endMarker}'.`);
return match[1].split(/\r?\n/);
return match[1]
.split(/\r?\n/)
.filter((val) => val.trim() !== '');
};

const nodeOptionsLines = parseSection(cliText,
Expand All @@ -24,6 +26,7 @@ const nodeOptionsLines = parseSection(cliText,
const v8OptionsLines = parseSection(cliText,
'<!-- node-options-v8 start -->',
'<!-- node-options-v8 end -->');

// Check the options are documented in alphabetical order.
assert.deepStrictEqual(nodeOptionsLines, [...nodeOptionsLines].sort());
assert.deepStrictEqual(v8OptionsLines, [...v8OptionsLines].sort());
Expand Down