Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
1ef2cf8
doc: anchor link parity between markdown and html-generated docs
foxxyz Jul 5, 2021
3743406
esm: consolidate ESM loader hooks
JakobJingleheimer Aug 25, 2021
5f3f3a5
v8: remove --harmony-top-level-await
GeoffreyBooth Sep 27, 2021
a8926d1
crypto: remove incorrect constructor invocation
gc Oct 4, 2021
d1d9f2d
doc: deprecate (doc-only) http abort related
dr-js Jan 18, 2021
f848553
doc: assign missing deprecation number
targos Oct 5, 2021
3b3aaa0
doc: fix typo in ESM example
tniessen Oct 1, 2021
5b074af
doc: fix typo in esm.md
MasonM Oct 1, 2021
71a94aa
doc: correct ESM load hook table header
JakobJingleheimer Sep 27, 2021
2d409ed
dns: refactor and use validators
VoltrexKeyva Sep 6, 2021
4116b6c
vm: add support for import assertions in dynamic imports
aduh95 Sep 5, 2021
38d8138
doc: add link to core promises tracking issue
mhdawson Oct 6, 2021
7e02124
dgram: add `nread` assertion to `UDPWrap::OnRecv`
RaisinTen Oct 3, 2021
6c091c7
doc: improve phrasing in fs.md
warlock1996 Sep 29, 2021
c3a744f
tools: warn about duplicates when generating AUTHORS file
Trott Oct 3, 2021
5668182
meta: use .mailmap to consolidate AUTHORS entries for ide
Trott Oct 7, 2021
fb7afb9
doc: format doc/guides using format-md task
Trott Oct 7, 2021
13d6a56
test: improve test coverage of `fs.ReadStream` with `FileHandle`
aduh95 Sep 6, 2021
7f50313
meta: update label-pr-config
Mesteery Sep 23, 2021
d8a36ee
test: fix "test/common/debugger" identify async function
gdccwxx Oct 6, 2021
07dae7f
test: replace .then chains with await
gdccwxx Oct 6, 2021
641b1bb
test: add test for readStream.path when fd is specified
Ayase-252 Oct 7, 2021
168020e
lib: refactor to use let
gdccwxx Oct 7, 2021
1224817
meta: consolidate AUTHORS entry for thw0rted
Trott Oct 9, 2021
2de57ed
build: make scripts in gyp run with right python
zcbenz Aug 11, 2021
6f6b99c
test: fix typos in whatwg-webstreams explanations
tniessen Oct 9, 2021
65b51d0
typings: fix declaration of primordials
targos Sep 26, 2021
c3a7a0b
typings: define types for timers binding
targos Sep 26, 2021
ca9a854
typings: add missing types to options and util bindings
targos Sep 26, 2021
7733b5e
typings: define types for os binding
targos Sep 26, 2021
93a48e0
doc: fix typos in n-api docs
igncp Oct 10, 2021
fff3135
meta: update AUTHORS
nodejs-github-bot Oct 10, 2021
93cecb4
meta: consolidate duplicate AUTHORS entries for hassaanp
Trott Oct 9, 2021
6f77d1a
doc: fix asyncLocalStorage.run() description
elegantcoder Oct 8, 2021
857af2b
src: add missing initialization
mhdawson Oct 8, 2021
91c3bf6
deps: upgrade Corepack to 0.10
arcanis Oct 8, 2021
dca5ac1
deps: suppress zlib compiler warnings
danbev Oct 6, 2021
5eb9402
doc: fix missing variable in deepStrictEqual example
olivierodo Oct 7, 2021
1d5857c
doc: format changelogs
Trott Oct 9, 2021
282b6eb
tools: fix ESLint update scripts
Trott Oct 10, 2021
43b97c7
tools: prepare ESLint rules for 8.0.0 requirements
Trott Oct 10, 2021
d9157aa
tools: update ESLint to 8.0.0
Trott Oct 10, 2021
d6a99b7
tools: remove @babel/plugin-syntax-top-level-await
Trott Oct 10, 2021
b72d693
tools: remove @bable/plugin-syntax-class-properties
Trott Oct 10, 2021
3611073
tools: remove @babel/plugin-syntax-import-assertions
Trott Oct 10, 2021
50f91ab
tools: udpate @babel/eslint-parser
Trott Oct 10, 2021
8bb3951
build: remove duplicate check for authors.yml
Trott Oct 10, 2021
80b4245
meta: consolidate AUTHORS information for geirha
Trott Oct 11, 2021
85b7385
doc: add pronouns for tniessen to README
tniessen Oct 11, 2021
dc7291d
doc: remove ESLint comments which were breaking the CJS/ESM toggles
Oct 11, 2021
faf9e28
src: remove usage of `AllocatedBuffer` from `stream_*`
RaisinTen Oct 3, 2021
bcd59d7
meta: consolidate AUTHORS entries for gabrielschulhof
Trott Oct 12, 2021
a672be5
net: throw error to object mode in Socket
watilde Oct 7, 2021
dbb2e6f
net: check objectMode first and then readble || writable
watilde Oct 7, 2021
4564a93
net: remove unused ObjectKeys
watilde Oct 7, 2021
1e15137
test: replace common port with specific number
watilde Oct 7, 2021
bc86084
net: check if option is undefined
watilde Oct 8, 2021
8fdabcb
deps: upgrade npm to 8.1.0
npm-robot Oct 14, 2021
2bfa87e
stream: fix fromAsyncGen
ronag Oct 18, 2021
4941550
2021-10-20, Version 16.12.0 (Current)
richardlau Oct 18, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix typo in ESM example
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
tniessen authored and danielleadams committed Oct 12, 2021
commit 3b3aaa0a374bdd86f900cbb55b5b6a0c8f444afb
2 changes: 1 addition & 1 deletion doc/api/esm.md
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ async function getPackageType(url) {
// Compose a file path to a package.json in the same directory,
// which may or may not exist
const packagePath = resolvePath(dir, 'package.json');
// Try to read the possibly non-existant package.json
// Try to read the possibly nonexistent package.json
const type = await readFile(packagePath, { encoding: 'utf8' })
.then((filestring) => JSON.parse(filestring).type)
.catch((err) => {
Expand Down