Skip to content

deps: update V8 to 9.6 #40488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 16 commits into from
Closed

deps: update V8 to 9.6 #40488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2205d6d
deps: update V8 to 9.6.180.14
targos Nov 21, 2021
f558c23
build: reset embedder string to "-node.0"
targos Nov 21, 2021
d7b5806
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
3f2405d
deps: V8: patch register-arm64.h
refack May 22, 2019
3f4e35e
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
a751fa9
deps: make v8.h compatible with VS2015
joaocgreis Sep 22, 2021
5a410aa
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
512d879
deps: silence irrelevant V8 warning
targos Jan 30, 2021
910d908
deps: silence irrelevant V8 warning
targos May 1, 2021
5400465
deps: disable trap handler for Windows cross-compiler
targos Oct 20, 2021
c5c3aec
deps: V8: patch jinja2 for Python 3.10 compat
targos Oct 5, 2021
1d83141
deps: V8: cherry-pick 2a0bc36dec12
targos Oct 11, 2021
ae29ea3
deps: V8: cherry-pick 7ae0b77628f6
rayw000 Nov 19, 2021
ac0e57f
deps: V8: cherry-pick cced52a97ee9
rayw000 Nov 21, 2021
e167cba
tools: update V8 gypfiles for 9.6
targos Oct 20, 2021
28a68bf
tools: disable trap handler for Windows cross-compiler
targos Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick 7ae0b77628f6 
Original commit message:

    [interpreter] Stop jump-table optimizing switch stms when spread overflows

    Bug: v8:12389
    Change-Id: I53c728ab0c8ba38c7dd96c7e1089f771ba44b9f0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289227
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77995}

Refs: v8/v8@7ae0b77

PR-URL: #40882
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@rayw000 @targos
rayw000 authored and targos committed Nov 21, 2021
commit ae29ea3af0477264c6c40e189d83c44ec152e865
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.10',
'v8_embedder_string': '-node.11',

##### V8 defaults for Node.js #####

Expand Down
33 changes: 22 additions & 11 deletions deps/v8/src/interpreter/bytecode-generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1889,17 +1889,28 @@ bool IsSwitchOptimizable(SwitchStatement* stmt, SwitchInfo* info) {
}

// GCC also jump-table optimizes switch statements with 6 cases or more.
if (!(static_cast<int>(info->covered_cases.size()) >=
FLAG_switch_table_min_cases &&
IsSpreadAcceptable(info->MaxCase() - info->MinCase(),
cases->length()))) {
// Invariant- covered_cases has all cases and only cases that will go in the
// jump table.
info->covered_cases.clear();
return false;
} else {
return true;
}
if (static_cast<int>(info->covered_cases.size()) >=
FLAG_switch_table_min_cases) {
// Due to case spread will be used as the size of jump-table,
// we need to check if it doesn't overflow by casting its
// min and max bounds to int64_t, and calculate if the difference is less
// than or equal to INT_MAX.
int64_t min = static_cast<int64_t>(info->MinCase());
int64_t max = static_cast<int64_t>(info->MaxCase());
int64_t spread = max - min + 1;

DCHECK_GT(spread, 0);

// Check if casted spread is acceptable and doesn't overflow.
if (spread <= INT_MAX &&
IsSpreadAcceptable(static_cast<int>(spread), cases->length())) {
return true;
}
}
// Invariant- covered_cases has all cases and only cases that will go in the
// jump table.
info->covered_cases.clear();
return false;
}

} // namespace
Expand Down