Skip to content

crypto: avoid double free #40380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 4 commits into from
Closed

crypto: avoid double free #40380

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
076d526
crypto: avoid double free
mhdawson Oct 8, 2021
0d4301e
Update src/crypto/crypto_util.h
mhdawson Oct 12, 2021
8bad858
Update src/crypto/crypto_util.h
mhdawson Oct 14, 2021
a04c343
Update src/crypto/crypto_util.h
mhdawson Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/crypto/crypto_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,9 +550,12 @@ struct EnginePointer {

inline void reset(ENGINE* engine_ = nullptr, bool finish_on_exit_ = false) {
if (engine != nullptr) {
if (finish_on_exit)
if (finish_on_exit) {
// this also does the equivalent of ENGINE_free
Comment thread
mhdawson marked this conversation as resolved.
Outdated
ENGINE_finish(engine);
Comment thread
mhdawson marked this conversation as resolved.
Outdated
ENGINE_free(engine);
} else {
ENGINE_free(engine);
Comment thread
mhdawson marked this conversation as resolved.
Outdated
}
}
engine = engine_;
finish_on_exit = finish_on_exit_;
Expand Down