Skip to content

lib: refactor internal debug variable #40364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gdccwxx wants to merge 1 commit into from
Closed

lib: refactor internal debug variable #40364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: refactor to use let 
move variable into each for loop
  • Loading branch information
@gdccwxx
gdccwxx committed Oct 7, 2021
commit 604d0d4ce547f9f60f55845a2af86bb5dc17e382
8 changes: 3 additions & 5 deletions lib/internal/debugger/inspect_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ function validateHandshake(requestKey, responseKey) {
}

function encodeFrameHybi17(payload) {
var i;

const dataLength = payload.length;

let singleByteLength;
Expand All @@ -71,7 +69,7 @@ function encodeFrameHybi17(payload) {
singleByteLength = kEightBytePayloadLengthField;
additionalLength = Buffer.alloc(8);
let remaining = dataLength;
for (i = 0; i < 8; ++i) {
for (let i = 0; i < 8; ++i) {
additionalLength[7 - i] = remaining & 0xFF;
remaining >>= 8;
}
Expand All @@ -92,7 +90,7 @@ function encodeFrameHybi17(payload) {

const mask = Buffer.alloc(4);
const masked = Buffer.alloc(dataLength);
for (i = 0; i < dataLength; ++i) {
for (let i = 0; i < dataLength; ++i) {
masked[i] = payload[i] ^ mask[i % kMaskingKeyWidthInBytes];
}

Expand Down Expand Up @@ -147,7 +145,7 @@ function decodeFrameHybi17(data) {
case kEightBytePayloadLengthField:
payloadOffset += 8;
payloadLength = 0;
for (var i = 0; i < 8; ++i) {
for (let i = 0; i < 8; ++i) {
payloadLength <<= 8;
payloadLength |= data[2 + i];
}
Expand Down