Skip to content

src: get embedder options on-demand #40357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

src: get embedder options on-demand #40357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc394bc
src: get embedder options on-demand
joyeecheung Oct 7, 2021
c9504e1
Update src/node_options.cc
joyeecheung Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/node_options.cc 
Co-authored-by: Anna Henningsen <github@addaleax.net>
  • Loading branch information
@joyeecheung @addaleax
joyeecheung and addaleax authored Oct 11, 2021
commit c9504e1dc51f814f7eb487ce0ab21e431fbfb832
8 changes: 4 additions & 4 deletions src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,15 +1072,15 @@ void GetEmbedderOptions(const FunctionCallbackInfo<Value>& args) {
Local<Context> context = env->context();
Local<Object> ret = Object::New(isolate);

ret->Set(context,
if (ret->Set(context,
FIXED_ONE_BYTE_STRING(env->isolate(), "shouldNotRegisterESMLoader"),
Boolean::New(isolate, env->should_not_register_esm_loader()))
.Check();
.IsNothing()) return;

ret->Set(context,
if (ret->Set(context,
FIXED_ONE_BYTE_STRING(env->isolate(), "noGlobalSearchPaths"),
Boolean::New(isolate, env->no_global_search_paths()))
.Check();
.IsNothing()) return;

args.GetReturnValue().Set(ret);
}
Expand Down