Skip to content

doc: update fast-track approval comment request #40316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 1 commit into from
Closed

doc: update fast-track approval comment request #40316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: update fast-track approval comment request 
Collaborators no longer need to add a comment for other collaborators
to upvote after adding the `fast-track` label as the GitHub actions
bot is configured to automatically add a comment after the label is
added.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva committed Oct 4, 2021
commit c4053ec4e221872c3787ccd860991b358ffcd7ee
4 changes: 2 additions & 2 deletions doc/guides/collaborator-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ delay. For example:
* Regressions that break the workflow (red CI or broken compilation).
* Regressions that happen right before a release, or reported soon after.

To propose fast-tracking a pull request, apply the `fast-track` label. Then add
a comment that collaborators can upvote.
To propose fast-tracking a pull request, apply the `fast-track` label. Then a
GitHub Action will add a comment that collaborators can upvote.

If someone disagrees with the fast-tracking request, remove the label. Do not
fast-track the pull request in that case.
Expand Down