Skip to content

stream_wrap: cast input to Buffer #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 2 commits into from
Closed

stream_wrap: cast input to Buffer #4031

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4237127
stream_wrap: error if stream has StringDecoder
indutny Dec 5, 2015
161af4f
fix
indutny Dec 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix
  • Loading branch information
@indutny
indutny committed Dec 7, 2015
commit 161af4f4ff3685e9c20886ce31760d68b96f3318
6 changes: 2 additions & 4 deletions test/parallel/test-stream-wrap-encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ const assert = require('assert');
const StreamWrap = require('_stream_wrap');
const Duplex = require('stream').Duplex;

var done = false;

var stream = new Duplex({
const stream = new Duplex({
read: function() {
},
write: function() {
Expand All @@ -16,7 +14,7 @@ var stream = new Duplex({

stream.setEncoding('ascii');

var wrap = new StreamWrap(stream);
const wrap = new StreamWrap(stream);

wrap.on('error', common.mustCall(function(err) {
assert(/StringDecoder/.test(err.message));
Expand Down