Skip to content

[v16.x-backport] deps: update V8 to 9.4 #40285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 16 commits into from
Oct 4, 2021
Merged

[v16.x-backport] deps: update V8 to 9.4 #40285

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
309c4f0
deps: update V8 to 9.4.146.19
targos Oct 2, 2021
4da73d0
build: reset embedder string to "-node.0"
targos Oct 2, 2021
b8aabd5
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
e810f07
deps: V8: patch register-arm64.h
refack May 22, 2019
88ae710
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
e981215
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
1aea6a7
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
22dcd3e
deps: silence irrelevant V8 warnings
targos Jan 30, 2021
be01694
deps: silence irrelevant V8 warning
targos May 1, 2021
807b68b
deps: V8: cherry-pick 00bb1a77c03e
RaisinTen Aug 21, 2021
150d816
deps: V8: cherry-pick bdcda72cd1d8
targos Aug 31, 2021
8de5eb8
deps: V8: cherry-pick 5681a6565828
targos Sep 6, 2021
5cc24e6
deps: V8: cherry-pick 9a607043cb31
gengjiawen Sep 9, 2021
a3db203
deps: make V8 9.4 abi-compatible with 9.0
targos Oct 2, 2021
e7046e0
deps: restore minimum ICU version to 68
targos Jul 20, 2021
f7c8274
tools: update V8 gypfiles for 9.4
targos Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick 00bb1a77c03e 
Original commit message:

    [date] Fix Date#getMinutes() test failures

    After building V8 using Clang (./out/x64.release/v8_build_config.json
    says that "is_clang" is true), I could reproduce the referenced bug
    report locally. Replacing the getMinutes() calls with getUTCMinutes()
    calls fixed the test failure.

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    Bug: v8:11200
    Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76367}

Refs: v8/v8@00bb1a7
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #39829
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@RaisinTen @targos
RaisinTen authored and targos committed Oct 4, 2021
commit 807b68b430ab0b742afba43167b32bb585e9d1a8
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
1 change: 1 addition & 0 deletions deps/v8/AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ Daniel Andersson <kodandersson@gmail.com>
Daniel Bevenius <daniel.bevenius@gmail.com>
Daniel Dromboski <dandromb@gmail.com>
Daniel James <dnljms@gmail.com>
Darshan Sen <raisinten@gmail.com>
David Carlier <devnexen@gmail.com>
David Manouchehri <david@davidmanouchehri.com>
Deepak Mohan <hop2deep@gmail.com>
Expand Down
10 changes: 5 additions & 5 deletions deps/v8/test/mjsunit/regress/regress-crbug-422858.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,21 @@
// found in the LICENSE file.

var date = new Date("2016/01/02 10:00 GMT-8")
assertEquals(0, date.getMinutes());
assertEquals(0, date.getUTCMinutes());
assertEquals(18, date.getUTCHours());

date = new Date("2016/01/02 10:00 GMT-12")
assertEquals(0, date.getMinutes());
assertEquals(0, date.getUTCMinutes());
assertEquals(22, date.getUTCHours());

date = new Date("2016/01/02 10:00 GMT-123")
assertEquals(23, date.getMinutes());
assertEquals(23, date.getUTCMinutes());
assertEquals(11, date.getUTCHours());

date = new Date("2016/01/02 10:00 GMT-0856")
assertEquals(56, date.getMinutes());
assertEquals(56, date.getUTCMinutes());
assertEquals(18, date.getUTCHours());

date = new Date("2016/01/02 10:00 GMT-08000")
assertEquals(NaN, date.getMinutes());
assertEquals(NaN, date.getUTCMinutes());
assertEquals(NaN, date.getUTCHours());