Skip to content

Fix minor time-of-check vs time-of-use pointer issues #40128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kokke wants to merge 2 commits into from
Closed

Fix minor time-of-check vs time-of-use pointer issues #40128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd91a66
src: fix time-of-use vs time-of-check "bugs"
kokke Sep 14, 2021
21f3971
src: implement changes suggested by @addaleax
kokke Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: implement changes suggested by @addaleax 
Refs: #40128
  • Loading branch information
@kokke
kokke authored Sep 27, 2021
commit 21f39713a83de4454b2c2522e98b1c112c18f0fb
2 changes: 1 addition & 1 deletion src/crypto/crypto_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,7 @@ int SecureContext::TicketKeyCallback(SSL* ssl,
return -1;
}

argv[2] = v8::True(env->isolate());
argv[2] = enc != 0 ? v8::True(env->isolate()) : v8::False(env->isolate());

Local<Value> ret;
if (!node::MakeCallback(
Expand Down