Skip to content

fs: add stream utilities to FileHandle #40009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 6 commits into from
Closed

fs: add stream utilities to FileHandle #40009

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51c212d
fs: add stream utilities to `FileHandle`
aduh95 Sep 5, 2021
158823a
fixup! fs: add stream utilities to `FileHandle`
aduh95 Sep 6, 2021
c5308bc
fixup! fs: add stream utilities to `FileHandle`
aduh95 Sep 6, 2021
ffd161b
fixup! fs: add stream utilities to FileHandle
aduh95 Sep 8, 2021
f4f2d85
fs: simplify `create(Read|Write)Stream` doc
aduh95 Sep 8, 2021
ab59886
fixup! fs: add stream utilities to `FileHandle`
aduh95 Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fs: add stream utilities to FileHandle 
Co-authored-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
@aduh95 @jasnell
aduh95 and jasnell committed Sep 8, 2021
commit ffd161bf40034e12662906fc64e1ff3fae27d03c
8 changes: 4 additions & 4 deletions lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ class FileHandle extends EventEmitterMixin(JSTransferable) {

/**
* @typedef {import('./streams').ReadStream
* } NodeJSReadStream
* } ReadStream
* @param {{
* encoding?: string;
* autoClose?: boolean;
Expand All @@ -269,7 +269,7 @@ class FileHandle extends EventEmitterMixin(JSTransferable) {
* end?: number;
* highWaterMark?: number;
* }} [options]
* @returns {NodeJSReadStream}
* @returns {ReadStream}
*/
Comment thread
aduh95 marked this conversation as resolved.
createReadStream(options = undefined) {
const { ReadStream } = lazyFsStreams();
Expand All @@ -278,14 +278,14 @@ class FileHandle extends EventEmitterMixin(JSTransferable) {

/**
* @typedef {import('./streams').WriteStream
* } NodeJSWriteStream
* } WriteStream
* @param {{
* encoding?: string;
* autoClose?: boolean;
* emitClose?: boolean;
Copy link
Copy Markdown
Member

@ronag ronag Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove autoClose & emitClose from here?

* start: number;
* }} [options]
* @returns {NodeJSWriteStream}
* @returns {WriteStream}
*/
Comment thread
aduh95 marked this conversation as resolved.
createWriteStream(options = undefined) {
const { WriteStream } = lazyFsStreams();
Expand Down