Skip to content

dns: default to verbatim=true in dns.lookup() #39987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
treysis wants to merge 18 commits into from
Closed

dns: default to verbatim=true in dns.lookup() #39987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
05bbc0e
dns: default to verbatim=true in dns.lookup()
bnoordhuis Jan 29, 2020
acdfa26
dns: fix dns.md
treysis Sep 3, 2021
36c0fe2
dns: added suggestion from comments
treysis Sep 3, 2021
09e0021
dns: fix test suite, part 1
treysis Sep 4, 2021
b352e42
dns: fix test suite part 2
treysis Sep 4, 2021
7956d2d
dns: minor lint fix
treysis Sep 4, 2021
9ca2309
dns: fix lint error in test-net-pingpong.js
treysis Sep 4, 2021
32a4bca
dns: fix test suite, part 3
treysis Sep 4, 2021
5822f5e
dns: fix lint errors
treysis Sep 4, 2021
82af5ec
dns: fix test suite, part 4
treysis Sep 4, 2021
0cb3a69
dns: fix test-net-dns-lookup.js
treysis Sep 4, 2021
dba92ad
dns: test suite fixes for CI
treysis Sep 5, 2021
f5b3eaa
dns: fix linter errors
treysis Sep 5, 2021
6ac9106
dns: fix test/pummel/test-net-pingpong.js
treysis Sep 5, 2021
e385c66
dns: trying to fix test-net-remote-address-port.js
treysis Sep 5, 2021
431f7b2
dns: try to fix test suite for CI
treysis Sep 5, 2021
424f34f
dns: test suite fix for CI node-test-commit-aix
treysis Sep 5, 2021
559c3f3
dns: apply suggestions from code review
treysis Sep 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dns: fix linter errors
  • Loading branch information
@treysis
treysis committed Sep 5, 2021
commit f5b3eaa45c14123078cf23ec9b731dcabf5eee19
2 changes: 1 addition & 1 deletion test/parallel/test-net-pingpong.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,4 @@ const tmpdir = require('../common/tmpdir');
tmpdir.refresh();
pingPongTest(common.PIPE);
pingPongTest(0);
common.hasIPv6 ? pingPongTest(0, '::1') : pingPongTest(0, '127.0.0.1');
if (common.hasIPv6) pingPongTest(0, '::1'); else pingPongTest(0, '127.0.0.1');
6 changes: 3 additions & 3 deletions test/parallel/test-net-remote-address-port.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ const remoteFamilyCandidates = ['IPv4'];
if (common.hasIPv6) remoteFamilyCandidates.push('IPv6');

const server = net.createServer(common.mustCall(function(socket) {
// test to see real value in CI log
// Test to see real value in CI log
assert.match(socket.remoteAddress,
/^127\.0\.0\.1$|^::1$|^::ffff:127.0.0.1$/);
// assert.ok(remoteAddrCandidates.includes(socket.remoteAddress));
/^127\.0\.0\.1$|^::1$|^::ffff:127\.0\.0\.1$/);
// REM: assert.ok(remoteAddrCandidates.includes(socket.remoteAddress));
assert.ok(remoteFamilyCandidates.includes(socket.remoteFamily));
assert.ok(socket.remotePort);
assert.notStrictEqual(socket.remotePort, this.address().port);
Expand Down
2 changes: 1 addition & 1 deletion test/pummel/test-net-pingpong.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function pingPongTest(host, on_complete) {

// All are run at once and will run on different ports.
pingPongTest(null);
common.hasIPv6 ? pingPongTest('::1') : pingPongTest('127.0.0.1');
if (common.hasIPv6) pingPongTest('::1'); else pingPongTest('127.0.0.1');

process.on('exit', function() {
assert.strictEqual(tests_run, common.hasIPv6 ? 3 : 2);
Expand Down