Skip to content

node: warn for Object.prototype.__* accessors common in security warnings #39824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmeck wants to merge 16 commits into
base: main
Choose a base branch
from
Open

node: warn for Object.prototype.__* accessors common in security warnings #39824

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
813dd33
node: warn accessors common in security warnings
bmeck Aug 20, 2021
c49435f
linter
bmeck Aug 20, 2021
fd4e664
Update lib/internal/bootstrap/pre_execution.js
bmeck Aug 21, 2021
bc2ef67
DEP
bmeck Aug 21, 2021
05ef3f2
DEP meta
bmeck Aug 21, 2021
9f266d6
Update doc/api/deprecations.md
bmeck Aug 21, 2021
301d5ea
fix nits
bmeck Aug 21, 2021
9198ad2
oops, define correct prop name
bmeck Aug 21, 2021
04fbd18
cleanup
bmeck Aug 21, 2021
083c842
Update test/parallel/test-object-proto-accessor-warning.js
bmeck Aug 21, 2021
308eb0e
linter
bmeck Aug 21, 2021
c55d04a
fix refactor regression
bmeck Aug 22, 2021
741f229
pendingDeprecation
bmeck Aug 22, 2021
4b73dde
test needs flag
bmeck Aug 22, 2021
bd37bbc
Update doc/api/deprecations.md
bmeck Mar 4, 2022
07faa4b
Apply suggestions from code review
bmeck Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
oops, define correct prop name
  • Loading branch information
@bmeck
bmeck committed Aug 21, 2021
commit 9198ad21f4d3c1cf3eedc040ceb009a3e0c78de9
5 changes: 3 additions & 2 deletions lib/internal/bootstrap/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ function initializeDeprecations() {
['__lookupGetter__', 'Object.getOwnPropertyDescriptor'],
['__lookupSetter__', 'Object.getOwnPropertyDescriptor'],
];
console.log('WTF');
for (let i = 0; i < legacy.length; i++) {
const prop = legacy[i][0];
const replacement = legacy[i][1];
Expand All @@ -367,7 +368,7 @@ function initializeDeprecations() {
if (protoDescriptor && 'value' in protoDescriptor) {
let value = protoDescriptor.value;
const writable = protoDescriptor.writable;
ObjectDefineProperty(ObjectPrototype, legacy[i], {
ObjectDefineProperty(ObjectPrototype, prop, {
get: deprecate(function() {
return value;
}, `${prop} is deprecated, use ${getReplacement} instead`, 'DEPXXXX'),
Expand All @@ -381,7 +382,7 @@ function initializeDeprecations() {
} else {
const getter = uncurryThis(protoDescriptor.get);
const setter = uncurryThis(protoDescriptor.set);
ObjectDefineProperty(ObjectPrototype, legacy[i], {
ObjectDefineProperty(ObjectPrototype, prop, {
get: deprecate(function() {
getter(this, value);
}, `${prop} is deprecated, use ${getReplacement} instead`, 'DEPXXXX'),
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-object-proto-accessor-warning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const common = require('../common');

process.on('warning', common.mustCall());
common.expectWarning('DeprecationWarning', '__proto__ is deprecated', 'DEP0XXX');

const obj = {};
// eslint-disable-next-line
Expand Down