Skip to content

dns: runtime deprecate type coercion of dns.lookup options #39793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 2 commits into from
Closed

dns: runtime deprecate type coercion of dns.lookup options #39793

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
061c10a
dns: runtime deprecate type coercion of `dns.lookup` options
aduh95 Aug 17, 2021
748feca
fixup! dns: runtime deprecate type coercion of `dns.lookup` options
aduh95 Sep 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! dns: runtime deprecate type coercion of dns.lookup options
  • Loading branch information
@aduh95
aduh95 committed Sep 12, 2021
commit 748fecaa8b96e9ab10bac19606665f896077ab8d
6 changes: 3 additions & 3 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2789,12 +2789,12 @@ deprecated and should no longer be used.
### DEP0153: `dns.lookup` and `dnsPromises.lookup` options type coercion
<!-- YAML
changes:
- version: v16.8.0
pr-url: https://github.com/nodejs/node/pull/38906
description: Documentation-only deprecation.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/39793
description: Runtime deprecation.
- version: v16.8.0
pr-url: https://github.com/nodejs/node/pull/38906
description: Documentation-only deprecation.
-->

Type: Runtime
Expand Down