Skip to content

lib: use validateArray #39774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 1 commit into from
Closed

lib: use validateArray #39774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: use validateArray 
The `validateArray()` validator could be used to cleanup validation
and keep consistency.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva committed Sep 3, 2021
commit c459a3bdfbf218167ddac94fa0404fa6962c13b4
9 changes: 3 additions & 6 deletions lib/internal/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const {
ArrayIsArray,
ArrayPrototypeForEach,
ArrayPrototypeMap,
ArrayPrototypePush,
Expand Down Expand Up @@ -122,11 +121,9 @@ class Worker extends EventEmitter {
constructor(filename, options = {}) {
super();
debug(`[${threadId}] create new worker`, filename, options);
if (options.execArgv && !ArrayIsArray(options.execArgv)) {
throw new ERR_INVALID_ARG_TYPE('options.execArgv',
'Array',
options.execArgv);
}
if (options.execArgv)
validateArray(options.execArgv, 'options.execArgv');

let argv;
if (options.argv) {
validateArray(options.argv, 'options.argv');
Expand Down