Skip to content

worker_threads: add brand checks for detached properties/methods #39763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

worker_threads: add brand checks for detached properties/methods #39763

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71d182e
worker_threads: add brand checks for detached properties/methods
jasnell Aug 13, 2021
9995f56
fixup! worker_threads: add brand checks for detached properties/methods
jasnell Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! worker_threads: add brand checks for detached properties/methods
  • Loading branch information
@jasnell
jasnell committed Aug 14, 2021
commit 9995f561d33d52ed81c6025d632a75578b4c664f
16 changes: 8 additions & 8 deletions lib/internal/worker/io.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,10 +417,10 @@ class BroadcastChannel extends EventTarget {
throw new DOMException('Message could not be posted.');
}

// TODO(@jasnell): The ref() method is Node.js specific and not part
// of the standard BroadcastChannel API definition. Typically we shouldn't
// extend Web Platform APIs with Node.js specific methods but ref and unref
// are a bit special. We may want to revisit this, however.
// The ref() method is Node.js specific and not part of the standard
// BroadcastChannel API definition. Typically we shouldn't extend Web
// Platform APIs with Node.js specific methods but ref and unref
// are a bit special.
ref() {
if (!isBroadcastChannel(this))
throw new ERR_INVALID_THIS('BroadcastChannel');
Expand All @@ -429,10 +429,10 @@ class BroadcastChannel extends EventTarget {
return this;
}

// TODO(@jasnell): The unref() method is Node.js specific and not part
// of the standard BroadcastChannel API definition. Typically we shouldn't
// extend Web Platform APIs with Node.js specific methods but ref and unref
// are a bit special. We may want to revisit this, however.
// The unref() method is Node.js specific and not part of the standard
// BroadcastChannel API definition. Typically we shouldn't extend Web
// Platform APIs with Node.js specific methods but ref and unref
// are a bit special.
unref() {
if (!isBroadcastChannel(this))
throw new ERR_INVALID_THIS('BroadcastChannel');
Expand Down