Skip to content

repl,worker: fix crash when SharedArrayBuffer disabled #39718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codebytere wants to merge 2 commits into from
Closed

repl,worker: fix crash when SharedArrayBuffer disabled #39718

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c3ed50
repl: fix crash when SharedArrayBuffer disabled
codebytere Aug 9, 2021
9ff558a
test: add a SharedArrayBuffer worker test
codebytere Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add a SharedArrayBuffer worker test
  • Loading branch information
@codebytere
codebytere committed Sep 2, 2021
commit 9ff558a547be7356d4a3686487e603478ab95b1b
17 changes: 17 additions & 0 deletions test/parallel/test-worker-no-sab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Flags: --no-harmony-sharedarraybuffer

'use strict';

const common = require('../common');
const assert = require('assert');
const { isMainThread, Worker } = require('worker_threads');

// Regression test for https://github.com/nodejs/node/issues/39717.

const w = new Worker(__filename);

w.on('exit', common.mustCall((status) => {
assert.strictEqual(status, 2);
}));

if (!isMainThread) process.exit(2);
Comment on lines +7 to +17
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Dec 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { isMainThread, Worker } = require('worker_threads');
// Regression test for https://github.com/nodejs/node/issues/39717.
const w = new Worker(__filename);
w.on('exit', common.mustCall((status) => {
assert.strictEqual(status, 2);
}));
if (!isMainThread) process.exit(2);
const { Worker } = require('worker_threads');
// Regression test for https://github.com/nodejs/node/issues/39717.
// Do not use isMainThread so that this test itself can be run inside a Worker.
if (!process.env.HAS_STARTED_WORKER) {
process.env.HAS_STARTED_WORKER = 1;
const w = new Worker(__filename);
w.on('exit', common.mustCall((status) => {
assert.strictEqual(status, 2);
}));
} else {
process.exit(2);
}

Copy link
Copy Markdown
Member

@Trott Trott Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codebytere Are you ok if we commit this suggestion, run tests, check with @BridgeAR if they can then approve the PR,, and hopefully land? Or is there something about this suggestion that would make you reluctant to do that?