Skip to content

stdio: call _undestroy() inside _destroy for stdout and stderr #39685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 1 commit into from
Closed

stdio: call _undestroy() inside _destroy for stdout and stderr #39685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bootstrap: call _undestroy() inside _destroy for stdout and stderr 
This change makes `process.stdout` and `process.stderr` to be
automatically undestroyed when ended/destrouyed, therefore making
it always possible to write/console.log to stdout.

Fixes: #39447
  • Loading branch information
@mcollina
mcollina committed Aug 9, 2021
commit f13ad43162c1b1911d50eec974272634ae48f77b
1 change: 1 addition & 0 deletions lib/internal/bootstrap/switches/is_main_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ function createWritableStdioStream(fd) {

function dummyDestroy(err, cb) {
cb(err);
this._undestroy();

// We need to emit 'close' anyway so that the closing
// of the stream is observable. We just make sure we
Expand Down
36 changes: 36 additions & 0 deletions test/parallel/test-stdio-undestroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const spawn = require('child_process').spawn;

if (process.argv[2] === 'child') {
process.stdout.destroy();
process.stderr.destroy();
console.log('stdout');
process.stdout.write('rocks\n');
console.error('stderr');
setTimeout(function() {
process.stderr.write('rocks too\n');
}, 10);
return;
}

const proc = spawn(process.execPath, [__filename, 'child'], { stdio: 'pipe' });

let stdout = '';
proc.stdout.setEncoding('utf8');
proc.stdout.on('data', common.mustCallAtLeast(function(chunk) {
stdout += chunk;
}, 1));

let stderr = '';
proc.stderr.setEncoding('utf8');
proc.stderr.on('data', common.mustCallAtLeast(function(chunk) {
stderr += chunk;
}, 1));

proc.on('exit', common.mustCall(function(exitCode) {
assert.strictEqual(exitCode, 0);
assert.strictEqual(stdout, 'stdout\nrocks\n');
assert.strictEqual(stderr, 'stderr\nrocks too\n');
}));