Skip to content

build: backport config for new CI infrastructure to v0.10 #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rvagg wants to merge 4 commits into from
Closed

build: backport config for new CI infrastructure to v0.10 #3965

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b769a4d
build: backport config for new CI infrastructure
rvagg Nov 3, 2015
d4894c6
build: backport tools/release.sh
rvagg Nov 19, 2015
b27df9d
doc: backport README.md
rvagg Nov 19, 2015
8ab062a
build,win: fix node.exe resource version
joaocgreis Sep 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build,win: fix node.exe resource version 
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but
passes it correctly to cl.exe. Hence, this workaround was made to
apply only to the resource file.

Fixes: #2963
PR-URL: #3053
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
  • Loading branch information
@joaocgreis @rvagg
joaocgreis authored and rvagg committed Dec 3, 2015
commit 8ab062a502510f144b3186b7dd93fc8c37c59496
4 changes: 2 additions & 2 deletions src/res/node.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ BEGIN
VALUE "CompanyName", "Joyent, Inc"
VALUE "ProductName", "Node.js"
VALUE "FileDescription", "Evented I/O for V8 JavaScript"
VALUE "FileVersion", NODE_VERSION_STRING
VALUE "ProductVersion", NODE_VERSION_STRING
VALUE "FileVersion", NODE_EXE_VERSION
VALUE "ProductVersion", NODE_EXE_VERSION
VALUE "OriginalFilename", "node.exe"
VALUE "InternalName", "node"
VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license."
Expand Down