Skip to content

[v16.x backport] stream: add stream.compose #39563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 7 commits into from
Closed

[v16.x backport] stream: add stream.compose #39563

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7663895
stream: add stream.compose
ronag Jun 18, 2021
5a5b44d
fixup
ronag Aug 23, 2021
aba75b3
fixup
ronag Aug 23, 2021
898514e
fixup
ronag Aug 24, 2021
e06d8ff
fixup
ronag Jul 7, 2021
36cb1a6
fixup
ronag Aug 24, 2021
2e16cc3
fixup
ronag Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Aug 24, 2021
commit 36cb1a6937587466194e9f701d9b9898ca7135ae
1 change: 0 additions & 1 deletion lib/internal/streams/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ function willEmitClose(stream) {
module.exports = {
isDisturbed,
kIsDisturbed,
isStream: isNodeStream,
isClosed,
isDestroyed,
isDuplexNodeStream,
Expand Down
4 changes: 2 additions & 2 deletions lib/stream/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const {

const {
isIterable,
isStream,
isNodeStream,
} = require('internal/streams/utils');

const pl = require('internal/streams/pipeline');
Expand All @@ -26,7 +26,7 @@ function pipeline(...streams) {
let signal;
const lastArg = streams[streams.length - 1];
if (lastArg && typeof lastArg === 'object' &&
!isStream(lastArg) && !isIterable(lastArg)) {
!isNodeStream(lastArg) && !isIterable(lastArg)) {
const options = ArrayPrototypePop(streams);
signal = options.signal;
validateAbortSignal(signal, 'options.signal');
Expand Down