Skip to content

webstream: convert premature close to AbortError #39524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 5 commits into from
+19 −6
Closed

webstream: convert premature close to AbortError #39524

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f024765
webstream: convert premature close to AbortError
ronag Jul 26, 2021
18ba68a
Update lib/internal/webstreams/adapters.js
ronag Jul 26, 2021
2ebc7ff
fixup
ronag Jul 26, 2021
1c18eb9
fixup
ronag Jul 27, 2021
6b90ae9
fiuxp
ronag Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
webstream: convert premature close to AbortError 
AbortError is a more "web" align alternative to
ERR_STREAM_PREMATURE_CLOSE.
  • Loading branch information
@ronag
ronag committed Jul 26, 2021
commit f0247654017b2efc0ac5eb5e7acd847247f5589a
5 changes: 5 additions & 0 deletions lib/internal/webstreams/adapters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ const {
ERR_INVALID_STATE,
ERR_STREAM_PREMATURE_CLOSE,
},
AbortError,
} = require('internal/errors');

const {
Expand Down Expand Up @@ -120,6 +121,10 @@ function newWritableStreamFromStreamWritable(streamWritable) {
}

const cleanup = finished(streamWritable, (error) => {
if (error?.code === 'ERR_STREAM_PREMATURE_CLOSE') {
error = new AbortError();
Comment thread
ronag marked this conversation as resolved.
Outdated
}

cleanup();
// This is a protection against non-standard, legacy streams
// that happen to emit an error event again after finished is called.
Expand Down