Skip to content

build: use Node.js 14 in commit-lint.yml #39506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

build: use Node.js 14 in commit-lint.yml #39506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: use Node.js 14 in commit-lint.yml 
All of our workflows use Node.js 14.x or 16.x except for commit-lint.yml
which has 12.x hard-coded. Update it to 14.x and change it to using an
environment variable so it is consistent with our other workflows.
  • Loading branch information
@Trott
Trott committed Jul 24, 2021
commit de0ec07ad42fcff0e093b9c19d01c4cbdaef4373
7 changes: 5 additions & 2 deletions .github/workflows/commit-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: "Commit messages adheres to guidelines at https://goo.gl/p2fr5Q"

on: [pull_request]

env:
NODE_VERSION: 14.x

jobs:
lint-commit-message:
runs-on: ubuntu-latest
Expand All @@ -10,10 +13,10 @@ jobs:
with:
# Last 100 commits should be enough for a PR
fetch-depth: 100
- name: Use Node.js 12
- name: Install Node.js
uses: actions/setup-node@v2
with:
node-version: 12.x
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit messages
run: |
echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"
Expand Down