Skip to content

events: allow the options argument to be null #39486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpinca wants to merge 1 commit into from
Closed

events: allow the options argument to be null #39486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
events: allow the options argument to be null 
Make `EventTarget.prototype.addEventListener()` accept `null` as a valid
value for the `options` argument.
  • Loading branch information
@lpinca
lpinca committed Jul 22, 2021
commit 82a9bbd4243f7fb9b28c049ac41c9a0def7b5212
3 changes: 3 additions & 0 deletions lib/internal/event_target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,9 @@ function shouldAddListener(listener) {
function validateEventListenerOptions(options) {
if (typeof options === 'boolean')
return { capture: options };

if (options === null)
return {};
validateObject(options, 'options', {
allowArray: true, allowFunction: true,
});
Expand Down
9 changes: 9 additions & 0 deletions test/parallel/test-eventtarget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,15 @@ let asyncTest = Promise.resolve();
eventTarget.dispatchEvent(event);
}

{
// The `options` argument can be `null`.
const eventTarget = new EventTarget();
const event = new Event('foo');
const fn = common.mustCall((event) => strictEqual(event.type, 'foo'));
eventTarget.addEventListener('foo', fn, null);
eventTarget.dispatchEvent(event);
}

{
const uncaughtException = common.mustCall((err, origin) => {
strictEqual(err.message, 'boom');
Expand Down