Skip to content

deps: update V8 to 9.3 #39469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 17 commits into from
Closed

deps: update V8 to 9.3 #39469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7e8a08e
deps: update V8 to 9.3.345.16
targos Aug 29, 2021
feeaaf5
build: reset embedder string to "-node.0"
targos Aug 29, 2021
679940d
src: update NODE_MODULE_VERSION to 96
targos Jul 20, 2021
f32e662
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
1573d4b
deps: V8: patch register-arm64.h
refack May 22, 2019
26a2044
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
e545184
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
8987789
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
738b155
deps: silence irrelevant V8 warnings
targos Jan 30, 2021
d6fbde3
deps: silence irrelevant V8 warning
targos May 1, 2021
8e52fc8
deps: V8: cherry-pick 81814ed44574
Aug 9, 2021
9814ad4
deps: V8: cherry-pick 00bb1a77c03e
RaisinTen Aug 21, 2021
c88584c
tools: update V8 gypfiles for 9.3
targos Jun 12, 2021
15488fd
build: adapt v8_pch.h to V8 9.3
targos Jun 20, 2021
50f6f65
test: adapt test-v8-flags to V8 9.3
targos Jun 20, 2021
3234e81
test: adapt test-util-inspect to V8 9.3
targos Jul 3, 2021
90e50e4
test: adapt test-fs-read to V8 9.3
targos Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: fix V8 build issue with inline methods 
PR-URL: #35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
@gengjiawen @targos
gengjiawen authored and targos committed Aug 29, 2021
commit 898778904540f3bf4c95f67f079a4833cf69d8b7
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.4',
'v8_embedder_string': '-node.5',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/src/objects/fixed-array-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,15 @@ bool FixedArray::is_the_hole(Isolate* isolate, int index) {
return get(isolate, index).IsTheHole(isolate);
}

#if !defined(_WIN32) || defined(_WIN64)
void FixedArray::set(int index, Smi value) {
DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map());
DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length()));
DCHECK(Object(value).IsSmi());
int offset = OffsetOfElementAt(index);
RELAXED_WRITE_FIELD(*this, offset, value);
}
#endif

void FixedArray::set(int index, Object value) {
DCHECK_NE(GetReadOnlyRoots().fixed_cow_array_map(), map());
Expand Down
11 changes: 11 additions & 0 deletions deps/v8/src/objects/fixed-array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,18 @@ class FixedArray
inline bool is_the_hole(Isolate* isolate, int index);

// Setter that doesn't need write barrier.
#if defined(_WIN32) && !defined(_WIN64)
inline void set(int index, Smi value) {
DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map());
DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length()));
DCHECK(Object(value).IsSmi());
int offset = OffsetOfElementAt(index);
RELAXED_WRITE_FIELD(*this, offset, value);
}
#else
inline void set(int index, Smi value);
#endif

// Setter with explicit barrier mode.
inline void set(int index, Object value, WriteBarrierMode mode);

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/objects/tagged-field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class TaggedField : public AllStatic {
int offset = 0);

static inline void Relaxed_Store(HeapObject host, T value);
static inline void Relaxed_Store(HeapObject host, int offset, T value);
static void Relaxed_Store(HeapObject host, int offset, T value);

static inline T Acquire_Load(HeapObject host, int offset = 0);
static inline T Acquire_Load_No_Unpack(PtrComprCageBase cage_base,
Expand Down