Skip to content

stream: fix performance regression #39254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscdex wants to merge 1 commit into from
Closed

stream: fix performance regression #39254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
stream: fix performance regression
  • Loading branch information
@mscdex
mscdex committed Jul 4, 2021
commit a1ee30ba549331ec85cad64d21269340873405e1
26 changes: 15 additions & 11 deletions lib/internal/streams/duplex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,23 @@ function Duplex(options) {
Readable.call(this, options);
Writable.call(this, options);

this.allowHalfOpen = options?.allowHalfOpen !== false;
if (options) {
this.allowHalfOpen = options.allowHalfOpen !== false;

if (options?.readable === false) {
this._readableState.readable = false;
this._readableState.ended = true;
this._readableState.endEmitted = true;
}
if (options.readable === false) {
this._readableState.readable = false;
this._readableState.ended = true;
this._readableState.endEmitted = true;
}

if (options?.writable === false) {
this._writableState.writable = false;
this._writableState.ending = true;
this._writableState.ended = true;
this._writableState.finished = true;
if (options.writable === false) {
this._writableState.writable = false;
this._writableState.ending = true;
this._writableState.ended = true;
this._writableState.finished = true;
}
} else {
this.allowHalfOpen = true;
}
}

Expand Down