Skip to content

doc: use "repository" in maintaining-V8 doc #39179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Jun 30, 2021
Merged

doc: use "repository" in maintaining-V8 doc #39179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: use "repository" in maintaining-V8 doc 
Use "repository" instead of "repo". This also adjusts capitalization in
a header that was already being modified to use "repository" because
even I couldn't bring myself to put that in a separate commit.

PR-URL: #39179
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@Trott
Trott committed Jun 30, 2021
commit b11d3f15b31e7a39d3f6a6e0d3f59f021144e813
8 changes: 4 additions & 4 deletions doc/guides/maintaining-V8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,9 @@ Refs: https://github.com/v8/v8/commit/a51f429772d1e796744244128c9feeab4c26a854
PR-URL: https://github.com/nodejs/node/pull/7833
```

* Open a PR against the `v6.x-staging` branch in the Node.js repo. Launch the
normal and [V8 CI][] using the Node.js CI system. We only needed to backport
to `v6.x` as the other LTS branches weren't affected by this bug.
* Open a PR against the `v6.x-staging` branch in the Node.js repository. Launch
the normal and [V8 CI][] using the Node.js CI system. We only needed to
backport to `v6.x` as the other LTS branches weren't affected by this bug.

### Backports identified by the V8 team

Expand Down Expand Up @@ -382,7 +382,7 @@ git node v8 major --branch=5.1-lkgr

This should be followed up with manual refloating of all relevant patches.

## Proposal: using a fork repo to track upstream V8
## Proposal: Using a fork repository to track upstream V8

The fact that Node.js keeps a vendored, potentially edited copy of V8 in deps/
makes the above processes a bit complicated. An alternative proposal would be to
Expand Down