Skip to content

doc: fix color contrast for anchor marks in dark mode #39168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Jul 5, 2021
Merged

doc: fix color contrast for anchor marks in dark mode #39168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: fix color contrast for anchor marks in dark mode 
Currently, in its dark mode, our website background color is #090C15 and
our anchor marks are #707070 for a contrast ratio of 3.94 to 1, falling
short of the WCAG AA 4.5 to 1. This changes the mark color in dark mode
only to #7A7A7A for a color contrast of 4.55 to 1.

PR-URL: #39168
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@Trott
Trott committed Jul 5, 2021
commit 68548fd661f87dbb69fc730e56cfd15ad8c8f9ca
4 changes: 3 additions & 1 deletion doc/api_assets/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
--color-fill-app: var(--white);
--color-fill-side-nav: var(--gray6);
--color-links: var(--green1);
--color-text-mark: var(--gray1);
--color-text-nav: var(--gray3);
--color-text-primary: var(--gray6);
--color-text-secondary: var(--green2);
Expand All @@ -42,6 +43,7 @@
--color-fill-app: var(--black1);
--color-fill-side-nav: var(--black3);
--color-links: var(--green5);
--color-text-mark: var(--gray5);
--color-text-primary: var(--white);
}

Expand Down Expand Up @@ -632,7 +634,7 @@ a code {

span > .mark,
span > .mark:visited {
color: #707070;
color: var(--color-text-mark);
position: absolute;
top: 0;
right: 0;
Expand Down